Skip to content

Conversation

@RobertJoonas
Copy link
Contributor

@RobertJoonas RobertJoonas commented Feb 12, 2025

Changes

Improve the UX of adding a scroll goal, moving it into a different tab, implementing automatic display name fill, and more. The UX can be tested in the review environment.

Tests

  • Automated tests have been adjusted

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@RobertJoonas RobertJoonas marked this pull request as draft February 12, 2025 10:03
@github-actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-5066

@RobertJoonas RobertJoonas marked this pull request as ready for review February 17, 2025 10:02
@RobertJoonas RobertJoonas changed the title Page Scroll Goals UI test Improve Page Scroll Goals UX Feb 17, 2025
@RobertJoonas RobertJoonas requested review from a team and ukutaht February 17, 2025 11:04
~H"""
<div id="scroll-form" class="py-2" x-data={@js} {@rest}>
<.label for={"scroll_threshold_input_#{@suffix}"}>
Scroll Percentage Threshold (0-100)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like there could be a useful tooltip we could add here with context what this means.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rather than a tooltip, an info paragraph (like in the custom events tab) would perhaps be better? Anyway, not sure if we need extra info there? (cc @metmarkosaric)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's pretty clear due to the headings but it doesn't hurt to add an info paragraph. how about:

Scroll Depth goals allow you to see how many people scroll beyond your desired scroll depth percentage threshold. Learn more in our docs.

maybe then it also makes sense to add an info paragraph to Pageview goals as well?

Pageview goals allow you to measure how many people visit a specific page or section of your site. Learn more in our docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense @metmarkosaric. I'll do that as part of the documentation task: https://3.basecamp.com/5308029/buckets/39034214/card_tables/cards/8195964494

phx-value-tab="scroll"
phx-target={@myself}
>
Scroll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should say "Scroll depth" instead. I can see myself getting confused as a user.

Copy link
Contributor Author

@RobertJoonas RobertJoonas Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the suggestion is to rename "Scroll" to "Scroll depth" here:

image

cc @metmarkosaric thoughts?

Copy link
Contributor

@metmarkosaric metmarkosaric Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Scroll Depth" is fine. does it fit on mobile screens etc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

does it fit on mobile screens etc?

Even on the smallest screens there's no overflow and it looks pretty okay (on most newer phones though, even "Custom Event" won't split onto two lines)

image

@RobertJoonas RobertJoonas added this pull request to the merge queue Feb 19, 2025
Merged via the queue into master with commit dfeb2c3 Feb 19, 2025
8 checks passed
@RobertJoonas RobertJoonas deleted the page-scroll-goal-ui branch February 19, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants