-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve Page Scroll Goals UX #5066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
c22ca79 to
db7d989
Compare
| ~H""" | ||
| <div id="scroll-form" class="py-2" x-data={@js} {@rest}> | ||
| <.label for={"scroll_threshold_input_#{@suffix}"}> | ||
| Scroll Percentage Threshold (0-100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels like there could be a useful tooltip we could add here with context what this means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather than a tooltip, an info paragraph (like in the custom events tab) would perhaps be better? Anyway, not sure if we need extra info there? (cc @metmarkosaric)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's pretty clear due to the headings but it doesn't hurt to add an info paragraph. how about:
Scroll Depth goals allow you to see how many people scroll beyond your desired scroll depth percentage threshold. Learn more in our docs.
maybe then it also makes sense to add an info paragraph to Pageview goals as well?
Pageview goals allow you to measure how many people visit a specific page or section of your site. Learn more in our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense @metmarkosaric. I'll do that as part of the documentation task: https://3.basecamp.com/5308029/buckets/39034214/card_tables/cards/8195964494
| phx-value-tab="scroll" | ||
| phx-target={@myself} | ||
| > | ||
| Scroll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should say "Scroll depth" instead. I can see myself getting confused as a user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Scroll Depth" is fine. does it fit on mobile screens etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.



Changes
Improve the UX of adding a scroll goal, moving it into a different tab, implementing automatic display name fill, and more. The UX can be tested in the review environment.
Tests
Changelog
Documentation
Dark mode