Script v2: Update tests relating to tagged a elements as well as examples from docs #5687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
force-pushed
the
script-v2/track-custom-event-svg
branch
from
f93ade6 to
27fe3ae
Compare
macobo
approved these changes
Sep 1, 2025
Contributor
macobo
left a comment
macobo
left a comment
There was a problem hiding this comment.
The syntax is kind of hacky but works. Thanks!
apata
changed the title
apata
commented
Sep 2, 2025
| }) | ||
| } | ||
|
|
||
| test.describe(`transformRequest examples from /docs work`, () => { |
Contributor
Author
There was a problem hiding this comment.
These should help verify that what we recommend to users actually works as intended
apata
force-pushed
the
script-v2/track-custom-event-svg
branch
from
4c8448c to
6874605
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There's a problem tracking tagged a elements if they're within svg tags.
urlproperty isn't added automatically. It's hard to fix using ES5-only logic without increasing script size or script complexity (if polyfilling only for .compat variants)Including the URL automatically with tagged links is convenience functionality that I propose we document with this edge case like this: plausible/docs#635.
This PR
Tests
Changelog
Documentation
Dark mode