Fix shared link hostname #5870
Merged
Fix shared link hostname #5870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apata
commented
Nov 4, 2025
| end | ||
|
|
||
| defp shared_link_dest(site, link) do | ||
| Routes.stats_path(PlausibleWeb.Endpoint, :shared_link, site.domain, auth: link.slug) |
Contributor
Author
There was a problem hiding this comment.
This has the benefit of ensuring proper encoding even for auth query parameter, which Plausible.Sites.shared_link_url/2 doesn't actually do. We could make use of this same logic in Plausible.Sites.shared_link_url/2, but it didn't make sense to me when I considered the relation between the modules Routes / Plausible.Sites.
apata
commented
Nov 4, 2025
Comment on lines
+1038
to
+1045
| test "doesn't share the same domain formatting with public dashboard links" do | ||
| site = new_site(domain: "a-café.fr") | ||
| link = insert(:shared_link, site: site) | ||
|
|
||
| assert "http://localhost:8000/a-café.fr" = PlausibleWeb.StatsView.pretty_stats_url(site) | ||
|
|
||
| assert "http://localhost:8000/share/a-caf%C3%A9.fr?" <> _q = | ||
| Sites.shared_link_url(site, link) |
Contributor
Author
There was a problem hiding this comment.
This codifies current non-ideal behavior that I noticed. It's worth thinking about how to unify the two and all our other route utils as well.
zoldar
approved these changes
Nov 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
* Fix missing share link hostname * Update changelog * Tests
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Nov 20, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds back the baseurl to shared links. It's needed for the links to be one-click shareable.
Tests
Changelog
Documentation
Dark mode