Patch to Sanne's empty states: Make tile component lv-embeddable
#5891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
RobertJoonas
approved these changes
Nov 18, 2025
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
Nice work Adam! I think this approach makes a ton of sense. The tile component shouldn't limit us in terms of technology. It should just be a UI thing.
Wondering if it might make sense to get rid of the deadview / form feature toggle for good? The Liveview one offers much better and responsive UX I imagine. Not pushing that into this PR though.
| slot(:inner_block) | ||
|
|
||
| def toggle(assigns) do | ||
| def toggle(%{conn: %Plug.Conn{}} = assigns) do |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
* Updated empty states across settings * Fix funnels and props functionality not hiding when toggled off - Add show_content? attribute to generic tile component - Ensure content is hidden when toggled off - Avoid rendering border and empty space when toggled off - Fix formatting * Update personal sites empty state * Make `tile` component lv-embeddable (#5891) * Use new tile component for funnels, goals, imports and custom properties - Update the settings live views to use the new tile component - Ensure tile component is updated when feature visibility is toggled - Extract `no_search_results` and `empty_state` components for better readability - Extract `highlighted` component - Update tests * Add empty states for team sites and simplify empty state logic - Hide top bar on `/sites` when empty state is shown - Extract empty state logic to a separate function - Show the same empty state for both personal and team sites, with different copy - extract search logic to a separate function - add tests for various empty states cases * Clean up: - remove HTTP feature visibility routes now that we're doing it 100% via LV - add tests for feature toggling - move "site_role" to where it's used (upgrade CTA), since there were already some feature-related function calls there - fix random test failures left * Fixup --------- Co-authored-by: Adam Rutkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR against #5874
This makes
tilecomponent play well in LV context where more dynamic approach is necessary. @RobertJoonas I've tried various things (including making a "live tile" - which seemed like an overkill) and this is the smallest friction I could come up with.