-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add report percentages to dashboard and details view #5923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,170
−674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
f11a50c to
bd04d96
Compare
939409c to
09f0011
Compare
- Enable horizontal scroll for details modal on mobile - Add responsive spacing and positioning to modal
09f0011 to
5360b49
Compare
- This isn't needed anymore since we now handle the tooltip logic in the MetricValue component
680d2dc to
8628a99
Compare
…ard, and show on hover in detailed view
- Unlike percentages, CR should show permanently.
fe9b493 to
53b4bdf
Compare
741cd5e to
db70e69
Compare
apata
reviewed
Dec 11, 2025
apata
reviewed
Dec 11, 2025
test/plausible_web/controllers/api/stats_controller/imported_test.exs
Outdated
Show resolved
Hide resolved
- Update tests to expect correct percentages (≤100%) when imported data is included. These tests will fail until the percentage calculation bug is fixed, documenting the expected behavior.
apata
reviewed
Dec 16, 2025
test/plausible_web/controllers/api/stats_controller/pages_test.exs
Outdated
Show resolved
Hide resolved
apata
approved these changes
Dec 16, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
* Update report percentages on dashboard and details view * Add percentages to Countries, Regions, and Cities reports * Add percentages to Channels, Sources, and UTM reports * Add percentages to top pages, entry pages, and exit pages reports * Update tests to include percentages * Change dashboard copy from title case to sentence case * Update details modal style * Make animations snappier * Introduce max height to modal and make inner content scrollable * Improve modal mobile design - Enable horizontal scroll for details modal on mobile - Add responsive spacing and positioning to modal * Added mobile tap behavior to external link in list report * Show tooltips only when in comparison mode or when the number is abbreviated * remove previously added showTooltip prop - This isn't needed anymore since we now handle the tooltip logic in the MetricValue component * Show long format upon hovering detailed view metrics * Added mobile tapping behaviour to detailed view * Added percentages to all detailed views * Add mobile swipe-to-close behavior for modal * Adjust sensitivity of modal drag to close * Use hammerjs for swipe-to-close modal behaviour * Prevent dragging if gesture starts inside table * Show 2 decimal places for percentages < 0.1% across dashboard * Adjust dark mode styles * Add hover effect to external link icon * Update tests to expect two-decimal percentages * Undo hammer install and revert to old modal styling * Remove CR and % columns from goals and custom props reports on dashboard, and show on hover in detailed view * Remove unused constants * Undo conversion rate on hover behaviour - Unlike percentages, CR should show permanently. * Show percentages permanently in custom props detailed view * Adjust width of conversion metrics column * Updated metric-value test * Update top-bar test * Added changelog entry * Fix test expectations for percentages with imported data - Update tests to expect correct percentages (≤100%) when imported data is included. These tests will fail until the percentage calculation bug is fixed, documenting the expected behavior. * Add imported_visitors to tests to ensure correct total_visitors calculation * Correct imported_visitors count in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Detailsbutton when all items are visible on the dashboard, so the detailed breakdown can be viewed at all times.CleanShot.2025-12-11.at.13.27.17.mp4
Tests
Changelog
Documentation
Dark mode