Validate password cookie for password-protected shared links on internal stats API requests #5932
Conversation
|
ukutaht
left a comment
ukutaht
left a comment
There was a problem hiding this comment.
One comment about naming, otherwise LGTM 👍
lib/plausible/site/shared_link.ex
Outdated
| end | ||
|
|
||
| def get_type(%__MODULE__{password_hash: hash}) when not is_nil(hash), do: :password_protected | ||
| def get_type(%__MODULE__{}), do: :unlisted |
There was a problem hiding this comment.
naming: :unlisted doesn't feel descriptive to me, not sure if it's some kind of terminology I'm not familiar with? How about :public?
There was a problem hiding this comment.
Thanks! I agree that it's a bit mystical, but that name was in the codebase already. I'm wary of :public because it might be confused with the fully public dashboard.
I can go simple with :with_password, :without_password or just def password_protected?(link) true / false? If we go with the boolean, matching on it isn't as pretty in with ... <- {function name}
There was a problem hiding this comment.
In plugins API, shared_link schema has a field :password_protected. I've decided to unify the checks with that in b8bb107
Changes
Tests
Changelog
Documentation
Dark mode