Display segment filters to anyone that can see the dashboard being filtered by the segment #5935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
ukutaht
reviewed
Dec 11, 2025
sanne-san
approved these changes
Dec 11, 2025
Member
|
So is that change about not displaying the red warning? |
Contributor
Author
@aerosol Yep! Before this, personal and site segment details weren't displayed to specific site roles, even though those roles were allowed to see the data filtered by the segment. The opacity had some benefits, since filters themselves can contain private info, but this PR removes that opacity. |
aerosol
reviewed
Dec 15, 2025
aerosol
approved these changes
Dec 15, 2025
Member
aerosol
left a comment
aerosol
left a comment
There was a problem hiding this comment.
Just minor changelog phrasing suggestion, I had trouble making sense of it
Co-authored-by: Adam Rutkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Changelog
Documentation
Dark mode