Reapply+bugfix: goals with custom props (#5936) #5944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
changed the title
aerosol
force-pushed
the
fixup-goals-custom-props
branch
from
0d14975 to
8e38748
Compare
Contributor
|
Is there any meaningful difference between custom props being I see that new goals will default to empty map when created via Elixir, but the same default is not set in postgres. I don't know, just having the same state represented in two different ways creates the need to account for both which seems unnecessary detail to have to deal with. Why don't we set the field to Sorry I missed this in review as well :( |
Member
Author
|
I think the difference is how unique constraints are firing. I dislike nullable columns too. Let me try to run this on top of another migration then |
This reverts commit 8e38748.
auto-merge was automatically disabled
December 11, 2025 11:07
Pull request was converted to draft
Member
Author
Member
Author
|
Done via #5946 |
ukutaht
approved these changes
Dec 11, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #5936 with some anti-nil defences