Fix feature that allows marking events as non-interactive #6001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apata
changed the title
apata
commented
Jan 14, 2026
| :revenue_reporting_amount, | ||
| :revenue_reporting_currency | ||
| :revenue_reporting_currency, | ||
| :interactive? |
Contributor
Author
There was a problem hiding this comment.
This here was the root cause. We correctly derived what the user wanted to set the interactive? value to, but we didn't allow it to pass to the event we built. It was ignored by ClickhouseEventV2.new/1 and the event was built with the default true value. This meant that logic to handle non-interactive events down the line never kicked in.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After this PR, when an event is built, it allows interactive?: false value to be set if it is set in the API request.
After this PR, we will quietly ignore attempts to override any system event to be non-interactive. This is to avoid unexpected behavior. To do so, this PR refactors and expands
SystemGoalsmodule toSystemEvents.Before this PR, the event request interactive value was ignored completely, so events built from API requests with
interactive: falsewere treated asinteractive: true.Existing tests didn't catch it, because session
is_bouncerelated tests create events with the event factory, rather than the ingestion pipeline.Tests
Changelog
Documentation
Dark mode