maybe_auto_subscribe was not passing a conn object into get_channel#89
Open
mviamari wants to merge 8 commits intoplay-co:masterfrom
mviamari:master
Open
maybe_auto_subscribe was not passing a conn object into get_channel#89mviamari wants to merge 8 commits intoplay-co:masterfrom mviamari:master
mviamari wants to merge 8 commits intoplay-co:masterfrom
mviamari:master
Conversation
…ise dict conflicts can arise.
Thi is done so that user presence on server can be pushed out to channels that request it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe_auto_subscribe in server.py was not passing in a conn object to the get_channel calls.
In most cases this isn't an issue, except when the autosubscribe channel in question requires a cookie for authorization. Without the conn object, creating the cookie for a potential create_channel rest call was not happening.
the get_channel calls in maybe_auto_subscribe now use the conn argument, if available, otherwise reverting to the current standard of using the user argument.