Skip to content

[FIX] Fix animation preview camera focus and add improvements #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willeastcott wants to merge 2 commits into from
Closed

[FIX] Fix animation preview camera focus and add improvements #1677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f46caac
[FIX] Fix animation preview camera focus and add improvements
willeastcott Jan 10, 2026
5bc9023
Initialize _cameraDistance
willeastcott Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions sass/editor/_editor-asset-anim-viewer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
width: 100%;
bottom: -40px;
background-color: $bcg-primary;
display: flex;
align-items: center;

.pcui-slider {
.pcui-slider-handle {
Expand All @@ -30,11 +32,7 @@
}

.anim-viewer-slider {
width: calc(100% - 75px);
}

.anim-viewer-play-button {
min-width: 51px;
flex-grow: 1;
}
}
}
Expand Down
38 changes: 32 additions & 6 deletions src/editor/inspector/assets/anim-viewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ class AnimViewer extends Container {

// listen for mouse events
let mouseDown = false;
this._zoom = 1;
this._cameraDistance = 3;
this._canvas.dom.addEventListener('mousedown', (e) => {
if (e.button === 0) {
mouseDown = true;
Expand All @@ -239,6 +241,12 @@ class AnimViewer extends Container {
requestAnimationFrame(() => this.render(0));
}
});
this._canvas.dom.addEventListener('wheel', (e) => {
e.preventDefault();
this._zoom = Math.min(Math.max(this._zoom + e.deltaY * 0.001, 0.1), 5);
this._camera.setLocalPosition(0, 0, this._cameraDistance * this._zoom);
requestAnimationFrame(() => this.render(0));
});
}

displayMessage(text) {
Expand All @@ -255,12 +263,12 @@ class AnimViewer extends Container {

_setPlaying() {
this._playing = true;
this._playButton.text = 'Pause';
this._playButton.icon = 'E135';
}

_setPaused() {
this._playing = false;
this._playButton.text = 'Play';
this._playButton.icon = 'E286';
}

set showSkeleton(value) {
Expand Down Expand Up @@ -292,7 +300,7 @@ class AnimViewer extends Container {

this._playButton = new Button({
class: 'anim-viewer-play-button',
text: 'Pause'
icon: 'E286'
});

this._playButton.on('click', () => {
Expand Down Expand Up @@ -522,7 +530,23 @@ class AnimViewer extends Container {
if (!this._showSkeleton) {
this._skeleton.update();
}
this._cameraOrigin.setLocalPosition(0, this._skeleton.boundingBox.center.y, 0);

// Compute combined bounding box from skeleton and mesh instances
const bounds = this._skeleton.boundingBox.clone();
if (this._entityMeshInstances) {
this._entityMeshInstances.forEach((mi) => {
bounds.add(mi.aabb);
});
}
if (this._renderComponents) {
this._renderComponents.forEach((render) => {
render.meshInstances.forEach((mi) => {
bounds.add(mi.aabb);
});
});
}

this._cameraOrigin.setLocalPosition(bounds.center);
this._rotationX = -15;
this._rotationY = 45;
this._cameraOrigin.setLocalEulerAngles(
Expand All @@ -531,8 +555,10 @@ class AnimViewer extends Container {
0
);

const { x, y, z } = this._skeleton.boundingBox.halfExtents;
this._camera.setLocalPosition(0, 0, Math.max(x, y, z) * 3.5);
const { x, y, z } = bounds.halfExtents;
this._cameraDistance = Math.max(x, y, z) * 3.5;
this._zoom = 1;
this._camera.setLocalPosition(0, 0, this._cameraDistance);
this._setupCamera = false;
}

Expand Down