Skip to content

[FIX] Fix ScriptComponent clone not handling awaiting scripts #8264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willeastcott wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIX] Fix ScriptComponent clone not handling awaiting scripts #8264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/framework/components/script/system.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ class ScriptComponentSystem extends ComponentSystem {
}

for (const key in entity.script._scriptsIndex) {
if (key.awaiting) {
order.splice(key.ind, 0, key);
const scriptEntry = entity.script._scriptsIndex[key];
if (scriptEntry.awaiting) {
order.splice(scriptEntry.ind, 0, key);
Comment on lines +124 to +126
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix correctly handles awaiting scripts during cloning, but there is no test coverage for this scenario. Consider adding a test that verifies cloning an entity with a ScriptComponent that has scripts in the "awaiting" state (i.e., scripts that are referenced but not yet registered). This would ensure the fix works as intended and prevent future regressions.

Copilot uses AI. Check for mistakes.
}
}

Expand Down