Cache validated FBO configurations in debug builds#8491
Merged
mvaligursky merged 2 commits intomainfrom Mar 3, 2026
Merged
Conversation
…bufferStatus calls In debug builds, gl.checkFramebufferStatus causes an expensive GPU sync (~16ms per call). This caches validated framebuffer format configurations per device using DeviceCache, so the check only runs once per unique combination of color formats, depth/stencil config, and sample count. Subsequent render targets with the same configuration skip the check. This is a debug-mode-only optimization - checkFramebufferStatus is already stripped from production builds via Debug.call. Made-with: Cursor
mvaligursky
added
performance
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes WebGL debug-mode render target initialization by caching framebuffer (FBO) completeness validation results per device, avoiding repeated gl.checkFramebufferStatus calls for previously validated attachment format configurations.
Changes:
- Added a per-device cache (
DeviceCache→Set) of validated FBO configuration keys. - Skips
gl.checkFramebufferStatuswhen an equivalent configuration was already validated. - Clears cached validations on context loss via
DeviceCache’sdevicelosthook.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gl.checkFramebufferStatuscalls in debug buildspackGpuMemoryDeviceCacheto store aSetof validated configuration keys per device, keyed by color buffer formats, depth/stencil config, sample count, and FBO type