Fix FOV slider default value in LOD streaming example#8510
Merged
mvaligursky merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
…streaming example The FOV slider defaulted to its minimum (10) because the cameraFov observer value was never set, while the camera was created with fov: 75. Made-with: Cursor
mvaligursky
added a commit
that referenced
this pull request
Mar 6, 2026
…streaming example (#8510) The FOV slider defaulted to its minimum (10) because the cameraFov observer value was never set, while the camera was created with fov: 75. Made-with: Cursor Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialize the
cameraFovobserver value to match the actual camera FOV of 75 in the LOD streaming example.Changes:
data.set('cameraFov', 75)so the UI slider displays the correct initial value instead of defaulting to the slider minimum of 10