Allow string color types #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused type definitions related to CSS colors in color.ts. - Updated the Serializable type in types-utils.ts to replace CssColor with string for better type consistency. These changes streamline the color utility functions and enhance type safety across the codebase.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR broadens the color type support for components by replacing the internal CssColor type with string, streamlining color utility functions and improving type consistency.
- Removed unused CSS color type definitions in color.ts.
- Updated the Serializable type in types-utils.ts to use string for color values.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/lib/src/utils/types-utils.ts | Replaced CssColor with string in the Serializable type definition. |
| packages/lib/src/utils/color.ts | Removed unused CSS color-related type definitions and commented code. |
Comments suppressed due to low confidence (1)
packages/lib/src/utils/types-utils.ts:38
- Ensure that replacing CssColor with string does not impact color value validation or formatting expectations in other parts of the codebase.
[K in keyof T]: T[K] extends Color ? string :
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR broaden the color type of components to support string. Closes #110
These changes streamline the color utility functions and enhance type safety across the codebase.