Skip to content

Update package metadata and repository links #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marklundin merged 1 commit into from
Apr 28, 2025
Merged

Update package metadata and repository links #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
"name": "playcanvas-react-monorepo",
"description": "A monorepo for PlayCanvas React renderer and examples. Please see the packages directory for more information.",
"private": true,
"license": "MIT",
Copy link
Contributor

@willeastcott willeastcott Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably you don't want the private field any more?

Copy link
Collaborator Author

@marklundin marklundin Apr 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's on the root monorepo package.json, which should be private, the library package.json is public though

"repository": {
"type": "git",
"url": "https://github.com/playcanvas/react/tree/main/packages/lib"
"url": "https://github.com/playcanvas/react"
},
"workspaces": [
"packages/*"
Expand Down
4 changes: 3 additions & 1 deletion packages/lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"description": "A React renderer for PlayCanvas – build interactive 3D applications using React's declarative paradigm.",
"homepage": "https://playcanvas-react.vercel.app",
"version": "0.3.0",
"license": "MIT",
"type": "module",
"sideEffects": false,
"main": "dist/index.js",
Expand Down Expand Up @@ -35,7 +36,8 @@
},
"repository": {
"type": "git",
"url": "https://github.com/playcanvas/react/tree/main/packages/lib"
"url": "https://github.com/playcanvas/react",
"directory": "packages/lib"
},
"files": [
"dist"
Expand Down
Loading