Prop validation fix #241
Merged
Prop validation fix #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…application - Updated the component removal logic to ensure that a component is only removed if it exists on the parent. - Added error handling when applying properties to instances to log any issues encountered during the process.
- Modified the focus method call to include a boolean parameter for better control over camera behavior during animations.
🦋 Changeset detectedLatest commit: e6a820a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with prop validation for components that have only getters without setters. The fix includes error handling for property assignment failures and adjusts the logic for determining which properties should be included in pseudo-public props.
- Adds try-catch error handling around property assignment to prevent crashes when setting read-only properties
- Updates prop filtering logic to include properties with getters but exclude setter-only properties
- Adds a safety check to prevent unnecessary component removal operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/lib/src/utils/validation.ts | Adds error handling for property assignment and fixes prop filtering logic for getter/setter properties |
| packages/lib/src/hooks/use-component.tsx | Adds safety check to prevent component removal when component doesn't exist |
| .changeset/thirty-yaks-occur.md | Documents the prop validation improvement as a patch release |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
slimbuck
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with prop validation where members only have a setter.