Exclude incompatible Application props from component schema #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the component definition function to accept an options object, allowing for exclusion of specific props and defining an API name. - Updated multiple components to utilize the new options structure for better clarity and maintainability. - Adjusted the applyProps function to accept a more generic props type.
- Added 'gamepads', 'scene', 'scripts', and 'assets' to the list of excluded props in the Application component. - Updated the corresponding exclude array to reflect these changes for improved prop management.
🦋 Changeset detectedLatest commit: d5eab91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
marklundin
force-pushed
the
fix-excluded-props
branch
from
98a4aa6 to
d5eab91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression whereby certain props were being incorrectly overridden. Fixes #277
Now props can be excluded using the
{ exclude: string[] }option which omits them from the component schema.Specifically 'mouse', 'touch', 'keyboard', 'gamepads', 'scene', 'scripts', 'assets' have been removed as these should not be set via
<Application />props.