Add deprecation warning for <OrbitControls/>
#280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a static property `scriptName` to the `NullScript` class for better identification. - Added a deprecation warning in the `OrbitControls` component, advising users to switch to `CameraControls` for future compatibility.
🦋 Changeset detectedLatest commit: 74f9503 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the legacy <OrbitControls/> component in favor of the newer CameraControls from the PlayCanvas engine. A deprecation warning has been added to inform users of the change, though the component remains functional for backward compatibility.
- Adds a deprecation warning to
<OrbitControls/>usingwarnOnceutility - Fixes
NullScriptclass by adding missingscriptNamestatic property - Includes changeset documentation for the deprecation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/lib/src/scripts/orbit-controls/index.tsx | Adds deprecation warning to OrbitControls component |
| packages/lib/src/components/Script.tsx | Adds scriptName property to NullScript class |
| .changeset/large-carpets-post.md | Documents the deprecation change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
marklundin
changed the title
<OrbitControls/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deprecation warning for the legacy
<OrbitControls/>component in favour of the newerCameraControlsfrom the engine.The component is still included but will be removed in future versions