Skip to content

Conversation

@here-abarany
Copy link
Contributor

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Fixes #1126

Purpose

Added JsonFacade functions writeToStream and prettyPrintToStream to support writing to an OutputStream without first writing the full string to memory.

Background Context

This allows for writing large files to a stream (such as to a file) without having to buffer the full string in memory beforehand. The JVM implementation forwards these calls to the appropriate functions in Jackson.

For now, the non-JVM implementations will build up the full string in memory. Ideally the strings should be written out as they are built up, but this would require a refactoring of the fromJs() function to support an interface to feed each string value and minimize the number of conversions to UTF-8 (for toBytes and writing to stream) or avoid conversions (for String). For now, this fulfills the interface guarantee while providing the same level of functionality as before.

@mkurz
Copy link
Member

mkurz commented Nov 11, 2025

I don't know why this was closed... i just pushed to it.

@mkurz
Copy link
Member

mkurz commented Nov 11, 2025

@here-abarany merged in #1257, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support writing JsValue directly to OutputStream

2 participants