Skip to content

Allow Play to setConfig + make sure to use correct factory #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkurz merged 2 commits into from
Nov 10, 2025
+13 −12
Merged

Allow Play to setConfig + make sure to use correct factory #1256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b75dbd
Use the factory from mapper; now we have setObjectMapper so the facto…
mkurz Nov 10, 2025
e6d4f14
Allow play to setConfig
mkurz Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions play-json/jvm/src/main/scala/play/api/libs/json/jackson/JacksonJson.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,27 +274,28 @@ private[play] object JacksonJson {
private var instance = JacksonJson(JsonConfig.settings)

/** Overrides the config. */
private[json] def setConfig(jsonConfig: JsonConfig): Unit = {
private[play] def setConfig(jsonConfig: JsonConfig): Unit = {
instance = JacksonJson(jsonConfig)
}

private[play] def get: JacksonJson = instance
}

private[play] case class JacksonJson(jsonConfig: JsonConfig) {
private val jsonFactory = new JsonFactoryBuilder()
.streamReadConstraints(jsonConfig.streamReadConstraints)
.streamWriteConstraints(jsonConfig.streamWriteConstraints)
.build()
private[play] case class JacksonJson(defaultMapperJsonConfig: JsonConfig) {
private var currentMapper: ObjectMapper = null
private val defaultMapper: ObjectMapper = JsonMapper
.builder(jsonFactory)
.builder(
new JsonFactoryBuilder()
.streamReadConstraints(defaultMapperJsonConfig.streamReadConstraints)
.streamWriteConstraints(defaultMapperJsonConfig.streamWriteConstraints)
.build()
)
.addModules(
new ParameterNamesModule(),
new Jdk8Module(),
new JavaTimeModule(),
new DefaultScalaModule(),
new PlayJsonMapperModule(jsonConfig),
new PlayJsonMapperModule(defaultMapperJsonConfig),
)
.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES)
.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
Expand All @@ -313,16 +314,16 @@ private[play] case class JacksonJson(jsonConfig: JsonConfig) {
}

private def stringJsonGenerator(out: java.io.StringWriter) =
jsonFactory.createGenerator(out)
mapper().getFactory.createGenerator(out)

def parseJsValue(data: Array[Byte]): JsValue =
mapper().readValue(jsonFactory.createParser(data), classOf[JsValue])
mapper().readValue(mapper().getFactory.createParser(data), classOf[JsValue])

def parseJsValue(input: String): JsValue =
mapper().readValue(jsonFactory.createParser(input), classOf[JsValue])
mapper().readValue(mapper().getFactory.createParser(input), classOf[JsValue])

def parseJsValue(stream: InputStream): JsValue =
mapper().readValue(jsonFactory.createParser(stream), classOf[JsValue])
mapper().readValue(mapper().getFactory.createParser(stream), classOf[JsValue])

private def withStringWriter[T](f: StringWriter => T): T = {
val sw = new StringWriter()
Expand Down
Loading