[#2079] use platform dependant compare for path#1094
Closed
flybyray wants to merge 1 commit intoplayframework:1.4.xfrom
Closed
[#2079] use platform dependant compare for path#1094flybyray wants to merge 1 commit intoplayframework:1.4.xfrom
flybyray wants to merge 1 commit intoplayframework:1.4.xfrom
Conversation
Contributor
|
@xael-fry I suggest to merge this PR. |
xael-fry
requested changes
Mar 9, 2017
| */ | ||
| public static void copy(File from, File to) { | ||
| if (from.getAbsolutePath().equals(to.getAbsolutePath())) { | ||
| if (0==from.toPath().compareTo(to.toPath())) { |
Member
There was a problem hiding this comment.
How can you be sure that getPath will compare the same file: ex with
File a = new File("C:\temp\TEST.TXT");
File b = new File("C:\temp\.\test.txt");
File should be detect as the are the same...
I will work on another solution + tests
Member
|
Closed in favor of #1120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://play.lighthouseapp.com/projects/57987-play-framework/tickets/2079