[#1112] Allow to limit the size of whole request or the size of one uploaded file in a request#1110
Merged
asolntsev merged 1 commit intoplayframework:masterfrom Feb 22, 2017
Merged
Conversation
Contributor
|
@xael-fry This is definitely good PR. I suggest to merge it ASAP. |
xael-fry
requested changes
Feb 22, 2017
Member
xael-fry
left a comment
xael-fry
left a comment
There was a problem hiding this comment.
Can you update the documentation with the new parameters?
xael-fry
changed the title
cbxp
force-pushed
the
uploadSizeFix
branch
2 times, most recently
from
224e374 to
195c9cd
Compare
Contributor
Author
|
@xael-fry We have updated the documentation. Without that, it's possible that hacker can upload 100TB file to server. |
xael-fry
requested changes
Feb 22, 2017
| @@ -612,12 +612,12 @@ public Map<String, String[]> parse(InputStream body) { | |||
| * The maximum size permitted for the complete request, as opposed to | |||
| * {@link #fileSizeMax}. A value of -1 indicates no maximum. | |||
Member
There was a problem hiding this comment.
fileSizeMax no longer exist as you rename it
…ze of one uploaded file in a request. The configuration parameters are: 'upload.sizeMax' and 'upload.fileSizeMax'. The defaults stay the same -1 which means 'unlimited'.
Contributor
|
@xael-fry Fixed parameter name in javadoc, thank you. What about setting default values to something reasonable? |
Member
|
@asolntsev I don't think we should define default value here, some user handle request size limit with a a front apache server, so setting new value may cause conflict when upgrading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…file in a request.
The configuration parameters are: 'upload.sizeMax' and 'upload.fileSizeMax'.
The defaults stay the same -1 which means 'unlimited'.