Skip to content

[#2089] dependencies upgrade:#1131

Merged
asolntsev merged 1 commit intoplayframework:masterfrom
dejan2609:deps-upgrade
May 10, 2017
Merged

[#2089] dependencies upgrade:#1131
asolntsev merged 1 commit intoplayframework:masterfrom
dejan2609:deps-upgrade

Conversation

@dejan2609
Copy link
Contributor

@dejan2609 dejan2609 commented Apr 12, 2017

* com.h2database:h2 1.4.193 -->> 1.4.194
* joda-time 2.9.7 -- >> 2.9.9
* mysql:mysql-connector-java 5.1.40 -->> 5.1.41
* org.codehaus.groovy:groovy-all 2.4.7 -->> 2.4.10

Related ticket: Upgrade dependencies

@dejan2609
Copy link
Contributor Author

dejan2609 commented Apr 12, 2017

Note: all checks passed, I just changed commit message little bit and pushed same changes again.

@asolntsev
Copy link
Contributor

@dejan2609 Thank you for the pull request! Sorry for the delay.
Could you h2 to 1.4.195 and groovy-all to 2.4.11?

@asolntsev asolntsev self-assigned this May 8, 2017
@asolntsev asolntsev added this to the 1.5.0 milestone May 8, 2017
@asolntsev
Copy link
Contributor

@dejan2609 Please note that groovy-all is already upgraded to 2.4.11 in master branch.

@dejan2609
Copy link
Contributor Author

@asolntsev let me upgrade h2 to 1.4.195

* com.h2database:h2 1.4.193 -->> 1.4.195
* joda-time 2.9.7 -- >> 2.9.9
* mysql:mysql-connector-java 5.1.40 -->> 5.1.41
@dejan2609
Copy link
Contributor Author

@asolntsev: done and rebased.

@asolntsev asolntsev self-requested a review May 10, 2017 19:42
@asolntsev asolntsev merged commit 0eacd06 into playframework:master May 10, 2017
@asolntsev
Copy link
Contributor

@dejan2609 Merged. Thank you!
PS. Why mysql-connector-java 5.1.41, not 6.0.6?

@dejan2609
Copy link
Contributor Author

dejan2609 commented May 10, 2017

@asolntsev nice point, I will include that upgrade into my next PR (along with few other dependencies).
I was slightly inclined to bump mysql-connector-java straight to 6.0.6... but then conservative part of my mind decided to go safe.

@dejan2609 dejan2609 deleted the deps-upgrade branch May 10, 2017 20:51
@dejan2609
Copy link
Contributor Author

@asolntsev just FYI: mysql-connector-java 6.x line is still not fully baked (i.e. only milestones are released so far):

@asolntsev
Copy link
Contributor

@dejan2609 Clear. Ok, thank you for information.

@flybyray
Copy link
Contributor

missing bouncy castle upgrade #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants