[#2122]FastTagsTest:ComparisonFailure:differences only in line separator#1147
Merged
asolntsev merged 3 commits intoplayframework:masterfrom Sep 18, 2017
Merged
Conversation
flybyray
force-pushed
the
lighthouse-2122-patch
branch
from
2ff5923 to
b317c64
Compare
xael-fry
requested changes
Aug 14, 2017
Member
xael-fry
left a comment
xael-fry
left a comment
There was a problem hiding this comment.
Could you rebase it, a PR sould only contains one fix.
Thanks
Contributor
Author
|
@xael-fry hi back again! how was the holiday! ;-) i try my best. but please recognize that i had requested many pulls which depend on each other and there was no response |
Member
|
@flybyray , it was busy holidays, moving back to France... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://play.lighthouseapp.com/projects/57987-play-framework/tickets/2122