Skip to content

[#1920] fixes: faster hot-reload in Play.DEV when no model changed #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flybyray wants to merge 1 commit into
base: 1.3.x
Choose a base branch
from
Open

[#1920] fixes: faster hot-reload in Play.DEV when no model changed #843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions framework/src/play/db/jpa/JPAPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public class JPAPlugin extends PlayPlugin {


public static boolean autoTxs = true;
public static boolean modelChanged = true;


@Override
Expand Down Expand Up @@ -172,10 +173,10 @@ public void onApplicationStart() {
cfg.addResource(mappingFile);
}

if (!dbConfig.getProperty("jpa.ddl", Play.mode.isDev() ? "update" : "none").equals("none")) {
if (modelChanged && !dbConfig.getProperty("jpa.ddl", Play.mode.isDev() ? "update" : "none").equals("none")) {
cfg.setProperty("hibernate.hbm2ddl.auto", dbConfig.getProperty("jpa.ddl", "update"));
}

Map<String, String> properties = dbConfig.getProperties();
properties.put("javax.persistence.transaction", "RESOURCE_LOCAL");
properties.put("javax.persistence.provider", "org.hibernate.ejb.HibernatePersistence");
Expand Down Expand Up @@ -794,4 +795,20 @@ public List<Object> list() {
return modelProperty;
}
}

@Override
public boolean detectClassesChange() {
if (!Play.started || Play.mode.isProd()) {
JPAPlugin.modelChanged = true;
} else {
JPAPlugin.modelChanged = false;
for (ApplicationClass applicationClass : Play.classes.getAssignableClasses(JPABase.class)) {
if (applicationClass.timestamp < applicationClass.javaFile.lastModified()) {
JPAPlugin.modelChanged = true;
break;
}
}
}
return super.detectClassesChange();
}
}