Remove hardcoded enforcement for RootPath property#2976
Open
contatodoaleoliveira wants to merge 1 commit intoplaygameservices:masterfrom
Open
Remove hardcoded enforcement for RootPath property#2976contatodoaleoliveira wants to merge 1 commit intoplaygameservices:masterfrom
contatodoaleoliveira wants to merge 1 commit intoplaygameservices:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2510
The
RootPathproperty on theGPGSUtilclass was hardcoded as a direct child folder inside "Assets". This prevented the plugin to be organized inside subfolder or to be wrapped inside a custom Unity Package (all of those attempts would result in in "Plugin error: GooglePlayGames folder was renamed").This pull requests fix that and adds a more reliable way of handling the project structure.
The solution is inspired by #2120 from @mirkoquaro.