Use Docker's chmod flag in copy and made playit no longer run as root. #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will create a home in /home, but setting the home makes Linux change /playit owner to be playit. We want it to stay as root as you can freely mess with files in a folder you own, regardless of the permission of that file.
Author
|
Notice after that setting the user home changes that folder permission. Also adduser seemed to ignore that |
Author
|
Added SIGTERM handler so the container stops sooner and so Playit can handle SIGTERM to exit gracefully (Assuming it can handle it already). Example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #94
Playit will now run without root and has it USER set to non-root.
The following in the Dockerfile allows users to change the ID.
ARG PLAYIT_GUID=2000
ARG PLAYIT_UUID=2000
https://docs.docker.com/build/guide/build-args/
https://docs.docker.com/reference/compose-file/build/#args
Ignore #95 , I didn't mess up at all and didn't copy the whole Dockerfile.