Made library more customizable #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
clemenceroumy
left a comment
clemenceroumy
left a comment
There was a problem hiding this comment.
Thank you for your PR and your work :)
I did a quick review on it
| child: SingleChildScrollView( | ||
| scrollDirection: Axis.horizontal, | ||
| child: Row( | ||
| children: widget.actions.map((type) { |
Collaborator
There was a problem hiding this comment.
I like the fact to allow detaching the action bar from the TextInput, though I think it should be an option.
I prefer to keep the structure of the input like it was previously : attached to the bottom of the input. Thus, I think there are 2 possibilities :
- The only thing needed is being able to set the action bar on the upper of the input. In this case, we should only set an option to choose where to put the bar (bottom or top, inside input).
- You want to detach the action bar to do what you want with it. In this case, you should give more availabilities than what you did, by choosing if you want to set it under or over the input, for example.
|
|
||
| ## Demo | ||
|  | ||
|  |
Collaborator
There was a problem hiding this comment.
Could you please do the same GIF as there was previously (one that show all the formatting options)
Comment on lines
+4
to
+5
| homepage: https://github.com/maripbekoff/markdown-editable-textinput | ||
| repository: https://github.com/maripbekoff/markdown-editable-textinput |
Collaborator
There was a problem hiding this comment.
Could you please re set the value as they were before :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.