nastashenko update boulder #15
Merged
+4,653
−1,694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ahead of the move from ProxySQL + MariaDB to Vitess + MySQL 8 in letsencrypt#8468. Vitess blocks partition related DDL, so partitions need to be removed from all schemas under `sa/db*`. The team has agreed that this drift from Production is acceptable because it lets us begin testing on Vitess and MySQL sooner. Separately, `thisUpdate` and `nextUpdate` were relying on an implicit `DEFAULT NULL`. We now make that explicit, matching how we define other DATETIME columns. Also, add a missing `DROP TABLE `incidents`;` to our combined schema migration. Part of letsencrypt#7736
…erter (letsencrypt#8494) Today, timestamp truncation happens for queries using `*borp.DbMap` but not `*borp.Transaction`. That means comparisons still see sub-seconds, but inserts into MariaDB `DATETIME` columns silently truncate them to whole seconds. On MySQL 8, the same queries will still include sub-seconds, but inserts into `DATETIME` columns will round to the nearest second instead of truncate. This leads to issues for queries like the one in `*StorageAuthority.UpdateCRLShard()`. When two CRL updaters write within the same second one may be rounded up to the next second. When the other updater attempts its own `UPDATE .. WHERE thisUpdate <= ?`, the condition fails because the stored timestamp now appears to be in the future. Ahead of the transition from ProxySQL + MariaDB to Vitess + MySQL 8 in letsencrypt#8468, update borp (letsencrypt/borp#12) to expose Transaction arguments to the BoulderTypeConverter, allowing it to truncate all timestamps passed through Transactions and keep behavior consistent across `*borp.DbMap` and `*borp.Transaction`, as well as MariaDB and MySQL 8. Part of letsencrypt#7736
…crypt#8500) Small comments to keep these three areas of our code in sync. Small fix to wording; not all of our limits are for a 1 week period.
) Add limiter stanza to the SFE's config-next JSON. This should have happened in [letsencrypt#8359](letsencrypt#8359). Also, Cleanup our Redis credentials and secrets. These were a little overly specific, especially now that we've dropped support for OCSP and thus ROCSP. Instead, rely on a single `boulder` user with the same permissions that each of the other users had.
If the primary perspective CAA check returns an error, return early rather than always kicking off the remote checks anyway. As part of this change, rearrange the code in DoCAA to more closely mirror the code in DoDCV. In particular, move the creation of the result protobuf into a helper function which can be called at both the early-return and late-return locations.
This brings in several new public suffixes under the Bangladesh (.bd) ccTLD. Also transitively update various golang.org/x/ packages. Fixes letsencrypt#8492
npurtova
force-pushed
the
nastashenko-boulder-update-3
branch
from
f463109 to
ebaeed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.