Skip to content

Reorganize Classic UI Theming part#1831

Merged
stevepiercy merged 23 commits into6.0from
classic-ui-theming-reorg-1645
Feb 26, 2025
Merged

Reorganize Classic UI Theming part#1831
stevepiercy merged 23 commits into6.0from
classic-ui-theming-reorg-1645

Conversation

@stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Jan 6, 2025

@stevepiercy
Copy link
Contributor Author

@plone/classicui-team please review.

@stevepiercy
Copy link
Contributor Author

First person to review this PR gets a 🍪 !

@petschki
@yurj
@MrTango
@jensens
@1letter

It has one section where I need some help to clarify it, please!

Co-authored-by: Peter Mathis <petschki@users.noreply.github.com>
@stevepiercy
Copy link
Contributor Author

We have to ignore the pull request preview build failure for a while. I just filed an issue with RTD at readthedocs/readthedocs.org#11912

petschki
petschki previously approved these changes Jan 13, 2025
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the restructuring here. Thank you!

@petschki
Copy link
Member

Where's my 🍪 😉

@stevepiercy
Copy link
Contributor Author

Where's my 🍪 😉

I'll bring a batch for the next PloneConf or sprint. 😁

I need help with this TODO, as I don't have the experience or knowledge. If y'all can give me some notes, I can wordsmith something together.

https://plone6--1831.org.readthedocs.build/classic-ui/theming/index.html

@stevepiercy
Copy link
Contributor Author

@petschki @yurj @MrTango @jensens @1letter

I need help with this TODO about choosing a theming method, as I don't have the experience or knowledge. If y'all can give me some notes or guidance, I can wordsmith something together and finish up this PR.

https://plone6--1831.org.readthedocs.build/classic-ui/theming/index.html

Thank you!

@ale-rt
Copy link
Member

ale-rt commented Feb 12, 2025

@stevepiercy what about merging master and merging this PR with the TODO?
We can add it later.

@stevepiercy
Copy link
Contributor Author

@petschki @yurj @MrTango @jensens @1letter

I need help with this TODO about choosing a theming method, as I don't have the experience or knowledge. If y'all can give me some notes or guidance, I can wordsmith something together and finish up this PR.

Since I got no response, I'm inclined to refer readers to get help to make a choice in the Classic UI Community Forum topic and Discord channel.

I'll revisit this when I get some time, but it can't be merged until helpful content replaces the todo.

@jensens
Copy link
Member

jensens commented Feb 24, 2025

I think that TTW is likely for testing or small-scale changes, especially for short-lived or prototype sites. It allows you to make minor adjustments without needing to dive into code or production-level setups. TTW can be convenient for quick experiments, for websites that don't require complex theming or short-lived websites.

Add-ons are definitely suited for production environments. An add-on allows you to keep your customization modular, and it provides a more structured approach to larger-scale theming. This method is ideal for more permanent or complex customizations since it enables easier maintenance and portability.

The customized Barceloneta theme, using Diazo, and creating a theme from scratch offer even more flexibility:

  • Barceloneta theme: Ideal for a starting point, especially if you want to tweak it as an existing, solid theme. You can customize its components and styles without starting from zero.

  • From Scratch: If your project requires something completely unique and none of the existing themes fit, building a theme from scratch would be the way to go. This is most appropriate for highly customized websites with distinct design requirements.

  • Diazo: Additional to an addon with customized or from-scratch and one of the more advanced methods. It offers control over the markup without customizing templates. It's great to have for more complex themes where content needs to remain flexible but you want full control over the markup. Disadvantage is possible slow down of the rendering process and more complex and more difficult to maintain theme.

In summary:

  • Use TTW for minor changes or testing.
  • Use Add-ons for production-level theming that needs scalability, maintainability, and modularity to customize Barceloneta or write from-scratch themes.
  • Use Diazo in your addon if you need to modify the markup without touching the page-templates.

@stevepiercy
Copy link
Contributor Author

@jensens that is beautiful. Thank you so much! I wordsmithed it into the index page in 95aeba3.

With that, I approve this PR, pending the merge of the related PR #1870 from @erral.

* Update tips submodules/plone.api submodules/volto

* Update tip submodules/volto

* Fix broken references (#1868)

* Fix broken references
- `link.svg`
- `_inc/_install-browser-reqs-volto.md`

* Fix linkcheck to bobtemplates

* Update tip submodules/volto

* Fix link

* Update tip submodules/plone.api

* Update tip submodules/volto

* initial structure of Theming with Diazo

* more doc

* initial structure of Theming with Diazo

* more doc

* - Add diazo to toctree
- Add note update getting help for choosing a theming method

* Clean up grammar, one sentence per line, MyST syntax

* Add language

* Move concepts and advice into a new Theme development advice section

* Minor tweaks

* Rename section to reflect its content

* Adjust heading level

* Update diazo.md

explain the purpose of each file created when addin a theme

* Update diazo.md

Link to Diazo docs.

* Update diazo.md

* - Make first mention of Diazo a term, already existing in the Glossary
- Reuse a sentence from Diazo docs that fills a critical gap in the introduction.
- Convert list of files descriptions into a definition list

* Tweak markup

* add tinymce templates docs

* Tidy up

* Add a label and important admonition about Template plugin removal in TinyMCE 7.0

* Remove important admonition about Template plugin

---------

Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy
Copy link
Contributor Author

Thank you @petschki, @jensens, and @erral for helping on this PR. Will merge at long last when it is all green.

@stevepiercy stevepiercy merged commit f0ba056 into 6.0 Feb 26, 2025
3 checks passed
@stevepiercy stevepiercy deleted the classic-ui-theming-reorg-1645 branch February 26, 2025 10:12
@github-project-automation github-project-automation bot moved this from in progress to Done in Alpine City Sprint 2025 Feb 26, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Classic-UI Team Feb 26, 2025
@github-project-automation github-project-automation bot moved this from Approved to Done in Plone Documentation Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Restructure Classic UI / Theming Chapter

5 participants