Skip to content

Update corepack enable to latest approach#1879

Merged
stevepiercy merged 3 commits intoplone:6.0from
Manas-Kenge:update-corepack
Mar 4, 2025
Merged

Update corepack enable to latest approach#1879
stevepiercy merged 3 commits intoplone:6.0from
Manas-Kenge:update-corepack

Conversation

@Manas-Kenge
Copy link
Contributor

@Manas-Kenge Manas-Kenge commented Mar 1, 2025

Issue number

Description

Updated all occurences of corepack enable to npm i -g corepack@latest && corepack enable

Add screenshots or links to a preview of the changes


📚 Documentation preview 📚: https://plone6--1879.org.readthedocs.build/

@Manas-Kenge
Copy link
Contributor Author

There is a reference under submodules/volto/docs that couldn't be committed automatically in this PR. Is it supposed to be in another repository?

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One amendment. I have concerns about the other instances as well. See the original issue #1877 for discussion.

@stevepiercy
Copy link
Contributor

There is a reference under submodules/volto/docs that couldn't be committed automatically in this PR. Is it supposed to be in another repository?

Please hold on this. We need to determine whether to make any other changes.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further discussion, we have a plan to resolve the issue in #1877 (comment). I've made suggestions accordingly.

@Manas-Kenge
Copy link
Contributor Author

Made changes as per #1877 (comment)

@stevepiercy stevepiercy merged commit 96eed09 into plone:6.0 Mar 4, 2025
2 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 4, 2025

Congratulations on your first merged pull request in this project! 🎉
Congratulations

Thank you for contributing, we are very proud of you! ❤️

@github-project-automation github-project-automation bot moved this from In Progress to Done in Plone Documentation Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update the corepack enable prerequisite to latest approach for installing pnpm as used in cookieplone templates

3 participants