Add tab example to MyST reference guide#1890
Merged
stevepiercy merged 3 commits intoplone:6.0from Mar 7, 2025
Merged
Conversation
Contributor
Author
|
@stevepiercy can you look into this? Should I make any changes? |
stevepiercy
requested changes
Mar 7, 2025
Contributor
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
Thanks for the @. I missed the notification.
This looks good. I added some narrative docs, requested changing colons to bickticks for consistency, and use of the nifty example directive.
Contributor
Author
No problem! Sorry for flooding with so many PRs. |
stevepiercy
approved these changes
Mar 7, 2025
github-project-automation
bot
moved this from In Progress
to Approved
in Plone Documentation
Contributor
I'm grateful for your work. Thank you! |
Contributor
|
@Manas-Kenge THX! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number
Description
Added a Tabs component example. I think we should update the description to make it more relevant to Plone. Currently, it is the same as Sphinx-Design, and I’m not sure if that’s the best approach.
Add screenshots or links to a preview of the changes
📚 Documentation preview 📚: https://plone6--1890.org.readthedocs.build/