Skip to content

Comments

Add documentation for disabling GlyphIcons in Classic UI#2006

Closed
bluesky-adi wants to merge 9 commits intoplone:6.0from
bluesky-adi:add-glyphicon-disable-docs
Closed

Add documentation for disabling GlyphIcons in Classic UI#2006
bluesky-adi wants to merge 9 commits intoplone:6.0from
bluesky-adi:add-glyphicon-disable-docs

Conversation

@bluesky-adi
Copy link

@bluesky-adi bluesky-adi commented Dec 14, 2025

What this PR does

Adds a new documentation section explaining how to disable GlyphIcons in Plone 6 Classic UI.

Why this is needed

Although GlyphIcons are no longer used by default in Plone 6, legacy themes or add-ons may still load them.
This documentation helps developers explicitly remove unused GlyphIcons resources and avoid accidental usage.

Scope

  • Documentation-only change
  • No code or behavior changes

Closes #694


📚 Documentation preview 📚: https://plone6--2006.org.readthedocs.build/classic-ui/icons.html

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 14, 2025

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, read Plone's Code of Conduct and Contribute to documentation, as this will greatly help the review process.

Welcome to the Plone community! 🎉

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've made some suggestions with explanations where needed. Please let me know if you have any further questions.

@github-project-automation github-project-automation bot moved this from New to In Progress in Plone Documentation Dec 15, 2025
@stevepiercy
Copy link
Contributor

See also this tip:

But update its path accordingly:

And use the {menuselection} directive using MyST (not reStructuredText) to have a nice rendering.

Note to self, I should add that to https://6.docs.plone.org/contributing/documentation/myst-reference.html, as well as guilabel for buttons, inputs, and other GUI elements.

bluesky-adi and others added 8 commits December 15, 2025 10:03
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@bluesky-adi
Copy link
Author

Thanks so much for the detailed review and explanations !

I’ve applied all the suggested changes:

  • Updated casing to GLYPHICONS® / GLYPHICONS
  • Added links to GLYPHICONS and Bootstrap Icons
  • Removed the redundant heading
  • Polished wording as suggested
    Please let me know if you’d also like me to add GLYPHICONS to the Vale spelling dictionary, or if this PR should stay limited to documentation content only.

Thanks again

@stevepiercy
Copy link
Contributor

@bluesky-adi I'm sorry to have wasted your time. Please see #694 (comment). We should have verified the original issue first.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Plone Documentation Dec 15, 2025
@bluesky-adi
Copy link
Author

No worries at all — thanks for the clarification and for the review.
Happy to verify behavior first before working on documentation next time.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add Instruction for Disabling GlyphIcons

2 participants