Start experiment with fields for Backrelations#29
Open
pbauer wants to merge 1 commit intoplone:masterfrom
Open
Start experiment with fields for Backrelations#29pbauer wants to merge 1 commit intoplone:masterfrom
pbauer wants to merge 1 commit intoplone:masterfrom
Conversation
…ist. The change sets RelatinValue items on the source and the target of a relatiing item if a field exists. The are still issues with updating relations when they are changed/deleted in the source/target. Also the architecure is not really great: * The fieldname has to be the same in source and target (maybe ok) * It creates two different relationValue objects instead of one. * It stores them on the objects and register them in intid and zc.relations * It would be nicer to have only one RelationValue but the then the BackRelatedItemsWidget would need to be more than a simple subsclass
|
@pbauer thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
Member
|
Is this still a thing or better close and forget? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far just a experiment...
The change sets RelationValues on the source and the target of a relating content if a field exists.
The are still issues with updating relations when they are changed/deleted in the source/target.
Also the architecure is not really great: