Skip to content

move template from plone.app.workflow to plone.app.layout #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MrTango
Copy link

@MrTango MrTango commented Feb 11, 2025

No description provided.

@mister-roboto
Copy link

@MrTango thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@MrTango MrTango changed the title remove unused updateSharingInfo view move template from plone.app.workflow to plone.app.layout Feb 12, 2025
@MrTango
Copy link
Author

MrTango commented Feb 12, 2025

Since we have some API code in the sharing view, we can't just move it to plone.app.layout.
We need to separate the UI code from the API code.
To do this we will create a new sharing view in plone.app.layout with a plone.app.layout.interfaces.IClassicUI BrowserLayer which subclasses the sharing view from plone.app.workflow and add's the classic UI related parts like the call and handle_form methods. As long as plone.app.layout is available, this will be the view one get's while calling for the sharing view. In Plone 7 plone.app.layout will become optional and when it is not present, one will get the base view in plone.app.workflow with the API related code, instead of the one from plone.app.layout. No code needs to change in plone.restapi.

For addon's overriding the sharing view, they need to update their Browserlayer to subclass from plone.app.layout.interfaces.IClassicUI BrowserLayer.

@MrTango MrTango marked this pull request as ready for review February 13, 2025 10:17
@MrTango MrTango requested a review from ale-rt February 14, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants