Skip to content

Fix status code in GET aliases service #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davisagli merged 2 commits into from
Feb 22, 2025
Merged

Fix status code in GET aliases service #1881

davisagli merged 2 commits into from
Feb 22, 2025

Conversation

@Faakhir30
Copy link
Member

@Faakhir30 Faakhir30 commented Feb 21, 2025 •
edited
Loading

Fixes #1862

Minor bug fix:
Aliases get service was returning 201 status code on get endpoints. Updated status code to 200.

  • Fixed aliases get service status code
  • Updated tests
  • Updated HTTP samples
  • Verified tests locally

📚 Documentation preview 📚: https://plonerestapi--1881.org.readthedocs.build/

@Faakhir30
Fix status code in GET aliases
ecb77f5 
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
@mister-roboto
Copy link

mister-roboto commented Feb 21, 2025

@Faakhir30 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@Faakhir30
Copy link
Member Author

Faakhir30 commented Feb 21, 2025

@jenkins-plone-org please run jobs

@Faakhir30 Faakhir30 self-assigned this Feb 21, 2025
stevepiercy
stevepiercy requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweak to the change log to help people searching for 201 Created and wondering when it changed. Otherwise LGTM. Thank you!

@Faakhir30 @stevepiercy
Update news
24be380 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
stevepiercy approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stevepiercy
Copy link
Contributor

stevepiercy commented Feb 22, 2025

@jenkins-plone-org please run jobs

davisagli
davisagli approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Faakhir30 @stevepiercy Thank you!

@davisagli davisagli merged commit a7d1200 into main Feb 22, 2025
24 checks passed
@davisagli davisagli deleted the fix_aliass_status_code branch February 22, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davisagli davisagli davisagli approved these changes

@stevepiercy stevepiercy stevepiercy approved these changes

@avoinea avoinea Awaiting requested review from avoinea

@mauritsvanrees mauritsvanrees Awaiting requested review from mauritsvanrees

Assignees

@Faakhir30 Faakhir30

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aliasses get service returns wrong status code

5 participants

@Faakhir30 @mister-roboto @stevepiercy @davisagli