Conversation
|
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
| self.assertEqual(response["items_total"], 1) | ||
| else: | ||
| # ... before it was not | ||
| self.assertEqual(response["items_total"], 0) |
There was a problem hiding this comment.
The expired items need to be published to make sure they are filtered out here because of their expiration date and not because of allowedRolesAndUsers
|
Also, keep in mind plone.restapi still supports Plone 5 and 6.0. So this will need to be a test that runs conditionally based on the Plone version. |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Does this rolechange gets backported to Plone 6? otherwise I'll check for the new roles in 6.1/2 separately ... |
4 participants
Test together with plone/Products.CMFPlone#4042
📚 Documentation preview 📚: https://plonerestapi--1936.org.readthedocs.build/