Consolidate test layers to share PLONE_RESTAPI_DX_FIXTURE base#1984
Open
Consolidate test layers to share PLONE_RESTAPI_DX_FIXTURE base#1984
Conversation
|
@jensens thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
jensens
force-pushed
the
consolidate-test-layers
branch
from
4ee62c3 to
25f0431
Compare
Make PloneRestApiDXPAMLayer and PloneRestApiDXIterateLayer extend PLONE_RESTAPI_DX_FIXTURE instead of duplicating its setup or using a separate lineage. This eliminates redundant ZCML + profile loading cycles, saving ~5-15s of layer setup per test run. Also switch test_boolean_value and test_indexers from FUNCTIONAL to INTEGRATION testing (they never make HTTP calls or commit transactions). Fix pre-existing test isolation bug in test_dxfield_publication where transaction.commit() in IntegrationTesting leaked portal_timezone into the shared DemoStorage. Fixes #1983
jensens
force-pushed
the
consolidate-test-layers
branch
from
25f0431 to
1b68229
Compare
Member
Author
|
@jenkins-plone-org please run jobs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PloneRestApiDXPAMLayerandPloneRestApiDXIterateLayerextendPLONE_RESTAPI_DX_FIXTUREinstead of duplicating its setup, eliminating redundant ZCML + profile loading cycles (~5-15s wall time saved per full test run)test_boolean_valueandtest_indexersfrom FUNCTIONAL to INTEGRATION testing (no HTTP calls or commits needed)test_dxfield_publicationwheretransaction.commit()in IntegrationTesting leakedportal_timezoneinto the shared DemoStorageFixes #1983
📚 Documentation preview 📚: https://plonerestapi--1984.org.readthedocs.build/