Conversation
✅ Deploy Preview for plone-components canceled.
|
sneridagh
approved these changes
Sep 14, 2024
Member
sneridagh
left a comment
There was a problem hiding this comment.
LGTM, although I dislike the "Sponsored OSS Docker images" naming.
For me it's the recommended community published Docker Image, the fact that it's right now in Docker Hub is circumstantial and could change in the future, eg. hosted in GH.
Collaborator
Author
|
Yeah, I'm not thrilled about the naming, either, but we have an "Official" Plone image (which IMO should be deprecated to avoid confusion for Plone 6) https://hub.docker.com/_/plone. I forgot to ask, in the Upgrade Guide, we mention that developers need to adapt their projects to the new way of doing things, but we don't tell them how to do that. I think that should also go into the Upgrade Guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the Upgrade Guide Cookieplone section. This also brings up new issues that must be resolved before the final Volto 18 release.
See also:
📚 Documentation preview 📚: https://volto--6290.org.readthedocs.build/