Exclude .storybook from ESLint's default hidden directory ignore list via .eslintignore to allow linting of Storybook configuration files#7898
Merged
wesleybl merged 6 commits intoplone:mainfrom Feb 20, 2026
Conversation
wesleybl
requested changes
Feb 19, 2026
Member
wesleybl
left a comment
There was a problem hiding this comment.
@Shyam-Raghuwanshi I've thought about it some more and I think the files in .storybook should be analyzed. So I think the best solution here is to explicitly tell ESLint not to ignore the .storybook folder.
wesleybl
requested changes
Feb 20, 2026
.storybook from ESLint's default hidden directory ignore list via .eslintignore to allow linting of Storybook configuration files
wesleybl
approved these changes
Feb 20, 2026
Member
|
@Shyam-Raghuwanshi Thanks! Could you please do a backport to Volto 18? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out ESLint-ignored files (e.g., files in hidden directories
like .storybook) before passing them to ESLint in the volto package
lint-staged configuration.
This prevents pre-commit hook failures when staging files from hidden
directories, as ESLint ignores these files by default and the
'--max-warnings=0' flag treats the warning as a fatal error.
Closes #7894