Conversation
Wagner3UB
requested review from
davisagli,
giuliaghisini,
pnicolli,
sneridagh and
stevepiercy
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
News clarification and a question to check rendering missed on the original source.
| <div | ||
| class="ui red basic label form-error-label" | ||
| > | ||
| Only 7-bit bytes characters are allowed. Cannot contain uppercase letters, special characters: <, >, &, #, /, ?, or others that are illegal in URLs. Cannot start with: _, aq_, @@, ++. Cannot end with __. Cannot be: request,contributors, ., .., "". Cannot contain new lines. |
There was a problem hiding this comment.
I just noticed this. Does the ampersand render to the screen, or does it need to be encoded?
There was a problem hiding this comment.
This good question got me curious and I checked, since this is a snapshot test result and should (theoretically) represent the result of rendering.
This is the actual string that is being render, the < was converted while the & was not, so I think it's safe to assume this is fine, at least for the sake of this PR.
https://github.com/plone/volto/blob/main/packages/volto/src/components/manage/Widgets/IdWidget.jsx#L30
https://github.com/plone/volto/blob/main/packages/volto/locales/en/LC_MESSAGES/volto.po#L2675
3 participants
#5619
Fix: screen readers were not announcing field errors or required state on form inputs.