David/GitHub action update cdn #389
Conversation
There was a problem hiding this comment.
non-zero or zero exit, it matters:
if sys.exit(0), the action is marked as success.
if sys.exit(1), the action is marked as a failure.
When should it marked as failure? When as success?
Should be marked as failure when the user needs to be notified as something.
Careful with the prints. It would be nice if w/ action success/failure status, the subtitle was whatever link the user had to follow. This is what github pages does when a new pages is published.
Can this also automatically update the CHANGELOG is a second commit?
src/py/scripts/update_cdn.py
Outdated
| sys.exit(0) | ||
|
|
||
| if pr.decode(): | ||
| print(f"Pull request '{branch}' already exists") |
There was a problem hiding this comment.
exit non-zero and print to stderr
There was a problem hiding this comment.
In this case, stderr prints empty if there's a PR with that branch
PS: Translated with AI
There was a problem hiding this comment.
pero por que? explicame toda la logica porfa
There was a problem hiding this comment.
Vale, en este endpoint decidi usar una bandera de gh llamada --silence que solo devuelve algo cuando no encuentra la rama, como solo es una validacion no veo la necesidad de procesar el json que devuelve si no le mando silence.
|
@davidangarita1 some changes were not resolved and I want to re-review the script. Please add more logging, especially intermediate values. |
There was a problem hiding this comment.
ok i just dont understand why you are not printing more to stderr.
stdout would be like if the user is expecting some out. if something unexpected happens, we print it to stderr. i think we can print to stderr and still return 0 from program if its unexpected but ok.
but not a big deal, i will approve.
|
@davidangarita1 please merge this with main and rerun |
|
@davidangarita1 once it is accepted remind me and we will trigger it automatically. |
| tag-check: ${{ env.IS_TAG_PUSH == 'true' && env.TAG || '' }} | ||
| summarize-news: ${{ env.IS_PR_TO_DEFAULT == 'true' && 'origin.txt updated.txt' || '' }} | ||
| - name: Check .editorconfig exists | ||
| run: | |
There was a problem hiding this comment.
i'm gonna change some things
3 participants
automatic update of plotly.js