Skip to content

Add Chart.Residual – Modified Lollipop Chart Implementation #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2025
Merged

Add Chart.Residual – Modified Lollipop Chart Implementation #493

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca1bab9
add Residue Chart
LibraChris Jul 30, 2025
ff447de
update Residual chart arguments
LibraChris Jul 30, 2025
07bc582
Add Documentation for Residual Chart
LibraChris Jul 30, 2025
8a1dad6
Rename to residual docs and add to solution folder
LibraChris Aug 7, 2025
7c123fe
Update Legend grouping for Residual charts
LibraChris Aug 7, 2025
d6235fd
Update Residual Legend options
LibraChris Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions src/Plotly.NET/ChartAPI/Chart2D.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6022,7 +6022,8 @@ module Chart2D =
/// <param name="reference">Sets the y coordinates for reference Y value.</param>
/// <param name="Name">Sets the trace name of the Y values. The trace name appear as the legend item and on hover</param>
/// <param name="ReferenceName">Sets the trace name of the reference Y values. The trace name appear as the legend item and on hover</param>
/// <param name="GroupName">Sets the name of the legendgroup for the three traces of this plot.</param>
/// <param name="LegendGroupData">Sets the name of the legendgroup for the data distribution trace of this plot.</param>
/// <param name="LegendGroupReference">Sets the name of the legendgroup for the reference trace of this plot.</param>
/// <param name="ShowMarkers">Determines whether or not an To show markers for each datum.</param>
/// <param name="ShowLegend">Determines whether or not an item corresponding to this trace is shown in the legend.</param>
/// <param name="Text">Sets a text associated with each datum for the Y values.</param>
Expand Down Expand Up @@ -6059,7 +6060,8 @@ module Chart2D =
reference: seq<#IConvertible>,
?Name: string,
?ReferenceName: string,
?GroupName: string,
?LegendGroupData: string,
?LegendGroupReference: string,
?ShowMarkers: bool,
?ShowLegend: bool,
?Text: #IConvertible,
Expand Down Expand Up @@ -6165,8 +6167,8 @@ module Chart2D =
)
|> GenericChart.mapTrace (
Trace2DStyle.Scatter(
LegendGroup = (defaultArg GroupName "Datapoints"),
LegendGroupTitle = (Title.init (Text = (defaultArg GroupName "Datapoints")))
?LegendGroup = LegendGroupData,
?LegendGroupTitle = if LegendGroupData.IsSome then Some (Title.init (Text = LegendGroupData.Value)) else None
)
)

Expand All @@ -6184,8 +6186,8 @@ module Chart2D =
?TextPosition = ReferenceTextPosition,
?MultiTextPosition = MultiReferenceTextPosition,
?Line = ReferenceLine,
LegendGroup = (defaultArg GroupName "Reference Line"),
LegendGroupTitle = (Title.init (Text = (defaultArg GroupName "Reference Line")))
?LegendGroup = LegendGroupReference,
?LegendGroupTitle = if LegendGroupReference.IsSome then Some (Title.init (Text = LegendGroupReference.Value)) else None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either make the title a separate argument or leave it out here. this still injects defaults not visible to the user, and might actually clash if i want to assign an already existing legendgroup that has a different title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kMutagene Removed the LegendGroupTitle

)
)
|> TraceStyle.Marker(
Expand All @@ -6206,7 +6208,8 @@ module Chart2D =
/// <param name="reference">Sets the y coordinates for reference Y value.</param>
/// <param name="Name">Sets the trace name of the Y values. The trace name appear as the legend item and on hover</param>
/// <param name="ReferenceName">Sets the trace name of the reference Y values. The trace name appear as the legend item and on hover</param>
/// <param name="GroupName">Sets the name of the legendgroup for the three traces of this plot.</param>
/// <param name="LegendGroupData">Sets the name of the legendgroup for the data distribution trace of this plot.</param>
/// <param name="LegendGroupReference">Sets the name of the legendgroup for the reference trace of this plot.</param>
/// <param name="ShowMarkers">Determines whether or not an To show markers for each datum.</param>
/// <param name="ShowLegend">Determines whether or not an item corresponding to this trace is shown in the legend.</param>
/// <param name="Text">Sets a text associated with each datum for the Y values.</param>
Expand Down Expand Up @@ -6242,7 +6245,8 @@ module Chart2D =
reference: seq<#IConvertible>,
?Name: string,
?ReferenceName: string,
?GroupName: string,
?LegendGroupData: string,
?LegendGroupReference: string,
?ShowMarkers: bool,
?ShowLegend: bool,
?Text: #IConvertible,
Expand Down Expand Up @@ -6281,7 +6285,8 @@ module Chart2D =
reference = reference,
?Name = Name,
?ReferenceName = ReferenceName,
?GroupName = GroupName,
?LegendGroupData = LegendGroupData,
?LegendGroupReference = LegendGroupReference,
?ShowMarkers = ShowMarkers,
?ShowLegend = ShowLegend,
?Text = Text,
Expand Down Expand Up @@ -6318,7 +6323,8 @@ module Chart2D =
/// <param name="referenceValue">Sets the y coordinate for reference Y value.</param>
/// <param name="Name">Sets the trace name of the Y values. The trace name appear as the legend item and on hover</param>
/// <param name="ReferenceName">Sets the trace name of the reference Y values. The trace name appear as the legend item and on hover</param>
/// <param name="GroupName">Sets the name of the legendgroup for the three traces of this plot.</param>
/// <param name="LegendGroupData">Sets the name of the legendgroup for the data distribution trace of this plot.</param>
/// <param name="LegendGroupReference">Sets the name of the legendgroup for the reference trace of this plot.</param>
/// <param name="ShowMarkers">Determines whether or not an To show markers for each datum.</param>
/// <param name="ShowLegend">Determines whether or not an item corresponding to this trace is shown in the legend.</param>
/// <param name="Text">Sets a text associated with each datum for the Y values.</param>
Expand Down Expand Up @@ -6354,7 +6360,8 @@ module Chart2D =
referenceValue: #IConvertible,
?Name: string,
?ReferenceName: string,
?GroupName: string,
?LegendGroupData :string,
?LegendGroupReference :string,
?ShowMarkers: bool,
?ShowLegend: bool,
?Text: #IConvertible,
Expand Down Expand Up @@ -6394,7 +6401,8 @@ module Chart2D =
reference = reference,
?Name = Name,
?ReferenceName = ReferenceName,
?GroupName = GroupName,
?LegendGroupData = LegendGroupData,
?LegendGroupReference = LegendGroupReference,
?ShowMarkers = ShowMarkers,
?ShowLegend = ShowLegend,
?Text = Text,
Expand Down Expand Up @@ -6435,7 +6443,8 @@ module Chart2D =
/// <param name="referenceValue">Sets the y coordinate for reference Y value.</param>
/// <param name="Name">Sets the trace name of the Y values. The trace name appear as the legend item and on hover</param>
/// <param name="ReferenceName">Sets the trace name of the reference Y values. The trace name appear as the legend item and on hover</param>
/// <param name="GroupName">Sets the name of the legendgroup for the three traces of this plot.</param>
/// <param name="LegendGroupData">Sets the name of the legendgroup for the data distribution trace of this plot.</param>
/// <param name="LegendGroupReference">Sets the name of the legendgroup for the reference trace of this plot.</param>
/// <param name="ShowMarkers">Determines whether or not an To show markers for each datum.</param>
/// <param name="ShowLegend">Determines whether or not an item corresponding to this trace is shown in the legend.</param>
/// <param name="Text">Sets a text associated with each datum for the Y values.</param>
Expand Down Expand Up @@ -6472,7 +6481,8 @@ module Chart2D =
referenceValue: #IConvertible,
?Name: string,
?ReferenceName: string,
?GroupName: string,
?LegendGroupData: string,
?LegendGroupReference: string,
?ShowMarkers: bool,
?ShowLegend: bool,
?Text: #IConvertible,
Expand Down Expand Up @@ -6511,7 +6521,8 @@ module Chart2D =
reference = reference,
?Name = Name,
?ReferenceName = ReferenceName,
?GroupName = GroupName,
?LegendGroupData = LegendGroupData,
?LegendGroupReference = LegendGroupReference,
?ShowMarkers = ShowMarkers,
?ShowLegend = ShowLegend,
?Text = Text,
Expand Down