Skip to content

fix: #283 Attempt to provide better typings to event handlers #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: #283 Attempt to provide better typings to event handlers #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions projects/plotly/src/lib/plotly.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { CommonModule } from '@angular/common';

import { PlotlyService } from './plotly.service';
import { Plotly } from './plotly.interface';
import {LegendClickEvent, PlotHoverEvent, PlotMouseEvent} from "plotly.js-dist-min";

// @dynamic
@Component({
Expand Down Expand Up @@ -77,13 +78,13 @@ export class PlotlyComponent implements OnInit, OnChanges, OnDestroy, DoCheck {
* @deprecated DEPRECATED: Reconsider using `(plotlyClick)` instead of `(click)` to avoid event conflict. Please check https://github.com/plotly/angular-plotly.js#FAQ
*/
click = output();
plotlyClick = output();
plotlyClick = output<PlotMouseEvent>();
clickAnnotation = output();
deselect = output();
doubleClick = output();
framework = output();
hover = output();
legendClick = output();
hover = output<PlotHoverEvent>();
legendClick = output<LegendClickEvent>();
legendDoubleClick = output();
/**
* @deprecated DEPRECATED: Event react is not list as an plotly.js event
Expand Down Expand Up @@ -124,7 +125,7 @@ export class PlotlyComponent implements OnInit, OnChanges, OnDestroy, DoCheck {
this.createPlot().then(() => {
const figure = this.createFigure();
this.initialized.emit(figure);
});
});
}

ngOnDestroy(): void {
Expand Down Expand Up @@ -237,7 +238,7 @@ export class PlotlyComponent implements OnInit, OnChanges, OnDestroy, DoCheck {
plotlyInstance.on(eventName, (data: any) => event.emit(data));
});

plotlyInstance.on('plotly_click', (data: any) => {
plotlyInstance.on('plotly_click', (data: PlotMouseEvent) => {
this.plotlyClick.emit(data);
});

Expand Down