-
Notifications
You must be signed in to change notification settings - Fork 40
Feature: AG Grid 33 #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature: AG Grid 33 #381
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6b6b551
Bump AG Grid version
KoolADE85 04f8c28
Remove rowSelection from AG Grid props
KoolADE85 10d17d1
Memoize component
KoolADE85 222ad7e
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 6fd20f8
Include sparklines module from ag-grid-enterprise
KoolADE85 1039821
Upgrade to AG Grid 33 instead of 34
KoolADE85 df6cd45
code cleanup
KoolADE85 e47d529
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 02ddf77
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 b2b9f55
code cleanup
KoolADE85 2cd615f
Merge branch 'refactor/functional-component' into feature/ag-grid-34
KoolADE85 813f024
Merge branch 'main' into feature/ag-grid-33
KoolADE85 528ed11
Merge branch 'main' into feature/ag-grid-33
KoolADE85 317666e
Merge branch 'main' into feature/ag-grid-33
KoolADE85 8c67d20
Remove default & legacy theme code
KoolADE85 edee45d
Ensure compatibility between legacy themes and modern themes
KoolADE85 e604f0c
Lazy load css for legacy themes
KoolADE85 739b1b7
Lazy load css for legacy themes
KoolADE85 ff98be1
Revert "Lazy load css for legacy themes"
KoolADE85 70251dd
Revert "Lazy load css for legacy themes"
KoolADE85 f189f5d
Add a `themes` module for external stylesheet usage
KoolADE85 65dffdf
remove unnecessary files
KoolADE85 cdfff73
Add e2e test for legacy theme css
KoolADE85 6d908c0
Merge branch 'main' into feature/ag-grid-33
KoolADE85 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import json | ||
| import os | ||
|
|
||
| def get_package_info(): | ||
| basepath = os.path.dirname(__file__) | ||
| filepath = os.path.abspath(os.path.join(basepath, 'package-info.json')) | ||
| with open(filepath) as f: | ||
| return json.load(f) | ||
|
|
||
| package = get_package_info() | ||
| __version__ = package['version'] | ||
| grid_version = package['dependencies']['ag-grid-community'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| from ._version import grid_version | ||
|
|
||
| _base_url = f"https://cdn.jsdelivr.net/npm/ag-grid-community@{grid_version}/styles" | ||
|
|
||
| BASE = f"{_base_url}/ag-grid.min.css" | ||
| ALPINE = f"{_base_url}/ag-theme-alpine.min.css" | ||
| BALHAM = f"{_base_url}/ag-theme-balham.min.css" | ||
| MATERIAL = f"{_base_url}/ag-theme-material.min.css" | ||
| QUARTZ = f"{_base_url}/ag-theme-quartz.min.css" |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.