Skip to content

Commit 8f50759

Browse files
committed
Revert "Fix no ouptut on error & use lts/iron on build windows."
This reverts commit 6deb92e.
1 parent 6deb92e commit 8f50759

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ jobs:
159159
pip install --no-cache-dir --upgrade -e .[ci,dev] --progress-bar off
160160
- run:
161161
command: |
162-
nvm install lts/iron && nvm use lts/iron
162+
nvm install 18 && nvm use 18
163163
- run:
164164
name: npm prereqs
165165
command: |

dash/development/update_components.py

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,15 @@ def bootstrap_components(components_source, concurrency, install_type):
4848
status_print(cmdstr)
4949

5050
with subprocess.Popen(
51-
cmd, shell=is_windows
51+
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=is_windows
5252
) as proc:
53-
proc.wait()
54-
status = proc.returncode
53+
out, err = proc.communicate()
54+
status = proc.poll()
5555

56-
if status:
56+
if err:
57+
status_print(("🛑 " if status else "") + err.decode(), file=sys.stderr)
58+
59+
if status or not out:
5760
status_print(
5861
f"🚨 Failed installing npm dependencies for component packages: {source_glob} (status={status}) 🚨",
5962
file=sys.stderr,
@@ -81,12 +84,15 @@ def build_components(components_source, concurrency):
8184
status_print(cmdstr)
8285

8386
with subprocess.Popen(
84-
cmd, shell=is_windows
87+
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=is_windows
8588
) as proc:
86-
proc.wait()
87-
status = proc.returncode
89+
out, err = proc.communicate()
90+
status = proc.poll()
91+
92+
if err:
93+
status_print(("🛑 " if status else "") + err.decode(), file=sys.stderr)
8894

89-
if status:
95+
if status or not out:
9096
status_print(
9197
f"🚨 Finished updating component packages: {source_glob} (status={status}) 🚨",
9298
file=sys.stderr,

0 commit comments

Comments
 (0)