Skip to content

Commit b245768

Browse files
authored
Merge branch 'dev' into update-flask
2 parents d28bf30 + dd74965 commit b245768

File tree

23 files changed

+2096
-417
lines changed

23 files changed

+2096
-417
lines changed

.github/workflows/testing.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ jobs:
135135
run: |
136136
cd tests
137137
pytest compliance/test_typing.py
138-
138+
139139
background-callbacks:
140-
name: Run Background Callback Tests (Python ${{ matrix.python-version }})
140+
name: Run Background & Async Callback Tests (Python ${{ matrix.python-version }})
141141
needs: [build, changes_filter]
142142
if: |
143143
(github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev')) ||
@@ -195,7 +195,7 @@ jobs:
195195
python -m pip install --upgrade pip wheel
196196
python -m pip install "setuptools<78.0.0"
197197
python -m pip install "selenium==4.32.0"
198-
find packages -name dash-*.whl -print -exec sh -c 'pip install "{}[ci,testing,dev,celery,diskcache]"' \;
198+
find packages -name dash-*.whl -print -exec sh -c 'pip install "{}[async,ci,testing,dev,celery,diskcache]"' \;
199199
200200
- name: Install Google Chrome
201201
run: |
@@ -253,13 +253,17 @@ jobs:
253253
run: |
254254
python -c "import redis; r = redis.Redis(host='localhost', port=6379, db=0); r.ping(); print('Successfully connected to Redis!')"
255255
256-
- name: Run Background Callback Tests
256+
- name: Build/Setup test components
257+
run: npm run setup-tests.py
258+
259+
- name: Run Background & Async Callback Tests
257260
run: |
258261
mkdir bgtests
259262
cp -r tests bgtests/tests
260263
cd bgtests
261264
touch __init__.py
262265
pytest --headless --nopercyfinalize tests/background_callback -v -s
266+
pytest --headless --nopercyfinalize tests/async_tests -v -s
263267
264268
table-unit:
265269
name: Table Unit/Lint Tests (Python ${{ matrix.python-version }})

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
1717
## Added
1818
- [#3294](https://github.com/plotly/dash/pull/3294) Added the ability to pass `allow_optional` to Input and State to allow callbacks to work even if these components are not in the dash layout.
1919
- [#3077](https://github.com/plotly/dash/pull/3077) Add new parameter `assets_path_ignore` to `dash.Dash()`. Closes [#3076](https://github.com/plotly/dash/issues/3076)
20-
- [#3202](https://github.com/plotly/dash/pull/3202) expose the closeMenuOnSelect option in dropdown component
20+
- [#3202](https://github.com/plotly/dash/pull/3202) expose the closeOnSelect option in dropdown component
2121

2222
## Changed
2323

components/dash-core-components/src/components/Dropdown.react.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ Dropdown.propTypes = {
148148
/**
149149
* If false, the menu of the dropdown will not close once a value is selected.
150150
*/
151-
closeMenuOnSelect: PropTypes.bool,
151+
closeOnSelect: PropTypes.bool,
152152

153153
/**
154154
* height of each option. Can be increased when label lengths would wrap around
@@ -219,7 +219,7 @@ Dropdown.defaultProps = {
219219
searchable: true,
220220
optionHeight: 35,
221221
maxHeight: 200,
222-
closeMenuOnSelect: true,
222+
closeOnSelect: true,
223223
persisted_props: ['value'],
224224
persistence_type: 'local',
225225
};

components/dash-core-components/src/fragments/Dropdown.react.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const RDProps = [
3333
'maxHeight',
3434
'style',
3535
'className',
36-
'closeMenuOnSelect',
36+
'closeOnSelect',
3737
];
3838

3939
const Dropdown = props => {

0 commit comments

Comments
 (0)