Speed up function _operation by 80%#3304
Merged
T4rk1n merged 4 commits intoplotly:devfrom Jun 2, 2025
Merged
Conversation
Here is an optimized version of your function. The largest bottleneck identified is from the unnecessary use of `dict(**kwargs)`, which creates a new dictionary from kwargs, but since `kwargs` is already a dictionary, this is just a redundant and potentially slower operation. You can use `kwargs` directly, which saves both CPU and memory. **Explanation:** - Returning `kwargs` as is avoids an unnecessary dictionary copy, achieving lower runtime and memory usage. - The return value is unchanged: the `"params"` entry will be the dictionary of arguments supplied via `**kwargs`. This is the fastest and leanest way to implement your functionality per the profiling results.
_operation by 80%_operation by 80%
Contributor
|
@T4rk1n do you believe the failing tests will be fixed if your latest CI changes are merged into this branch? (This seems like a simple and correct fix.) |
Contributor
Yes, the failing tests are not related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 80% (0.80x) speedup for
_operationindash/_patch.py⏱️ Runtime :
477 microseconds→264 microseconds(best of393runs)📝 Explanation and details
The largest bottleneck identified is from the unnecessary use of
dict(**kwargs), which creates a new dictionary from kwargs, but sincekwargsis already a dictionary, this is just a redundant and potentially slower operation. You can usekwargsdirectly, which saves both CPU and memory.Explanation:
kwargsas is avoids an unnecessary dictionary copy, achieving lower runtime and memory usage."params"entry will be the dictionary of arguments supplied via**kwargs.This is the fastest and leanest way to implement your functionality per the profiling results.
✅ Correctness verification report:
🌀 Generated Regression Tests Details