dcc: refactor input #3398
Draft
dcc: refactor input #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoolADE85
commented
Aug 8, 2025
| @@ -68,7 +68,7 @@ def generate_any(*_): | |||
|
|
|||
|
|
|||
| def generate_enum(prop_info): | |||
| values = str([v["value"] for v in prop_info["value"]]) | |||
| values = str([v.get("value") for v in prop_info["value"]]) | |||
There was a problem hiding this comment.
These component generation changes fix an Exception raised when Typescript enums contain undefined as a possible option.
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
2b47c08 to
5a49f13
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
2 times, most recently
from
d7fa1ac to
01dac37
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
01dac37 to
1653281
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add scaffolding to write dcc components in Typescript.
It refactors the Input dcc component to be a function-component written in Typescript and with new CSS rules applied.
Contributor Checklist
optionals
CHANGELOG.md